This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-978] Higher Order Gradient Support sqrt
, cbrt
.
#15474
Merged
apeforest
merged 5 commits into
apache:master
from
kshitij12345:develop/add-higher-order/sqrt-cbrt
Sep 6, 2019
Merged
[MXNET-978] Higher Order Gradient Support sqrt
, cbrt
.
#15474
apeforest
merged 5 commits into
apache:master
from
kshitij12345:develop/add-higher-order/sqrt-cbrt
Sep 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot add [pr-awaiting-review, Backend, Operator] |
marcoabreu
added
Backend
Issues related to the backend of MXNet
Operator
pr-awaiting-review
PR is waiting for code review
labels
Jul 8, 2019
apeforest
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kshitij12345 is this PR good to go for merge? |
As of now there are no changes with this PR. However I would like to know @apeforest opinion on #15531. If that is approved, I'll make changes in all other PR to use the machinery introduced by it. |
@kshitij12345 Can you rebase with the latest master and then this PR will be good to go :) |
…to develop/add-higher-order/sqrt-cbrt
@kshitij12345 gentle ping to rebase so we can merge, thanks! |
…to develop/add-higher-order/sqrt-cbrt
@roywei Have retriggered and successfully run. |
gyshi
pushed a commit
to gyshi/incubator-mxnet
that referenced
this pull request
Sep 7, 2019
* support sqrt, cbrt for higher order grad * add relevant tests * remove unnecessary variable
gyshi
pushed a commit
to gyshi/incubator-mxnet
that referenced
this pull request
Sep 7, 2019
* support sqrt, cbrt for higher order grad * add relevant tests * remove unnecessary variable
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* support sqrt, cbrt for higher order grad * add relevant tests * remove unnecessary variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Backend
Issues related to the backend of MXNet
Operator
pr-awaiting-review
PR is waiting for code review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR intends to add support for higher order gradient for
sqrt
,cbrt
.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
sqrt
,cbrt
.